Skip to content

Fix unbound local crash on handling aws lambda exception #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
untitaker merged 1 commit into from Jan 18, 2021
Merged

Fix unbound local crash on handling aws lambda exception #977

untitaker merged 1 commit into from Jan 18, 2021
+1 −1

Conversation

@ghost
Copy link

@ghost ghost commented Jan 14, 2021

Fix for #974

@untitaker untitaker closed this Jan 14, 2021
@untitaker untitaker reopened this Jan 14, 2021
@ghost
Copy link
Author

ghost commented Jan 14, 2021

Don't know how to get the aws lambda tests to actually run. Until then, the coverage test will not pass.

@ghost ghost marked this pull request as ready for review January 14, 2021 18:40
@ghost
Copy link
Author

ghost commented Jan 14, 2021

Fix for exception:

    UnboundLocalError: local variable 'timeout_thread' referenced before assignment
    Traceback (most recent call last):
       File "/usr/local/lib/python3.8/dist-packages/sentry_sdk/integrations/aws_lambda.py", line 160, in sentry_handler
        if timeout_thread:

@untitaker untitaker merged commit 2af3274 into getsentry:master Jan 18, 2021
@untitaker
Copy link
Member

untitaker commented Jan 18, 2021

Thanks!

This was referenced Mar 8, 2021
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 16, 2021
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@untitaker